Comments Title: Count toggle working in 'Singular' editing mode (fix) #40728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
changed the title
cbravobernal
added
[Block] Comments Title
|
Size Change: +22 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
13 tasks
ockham
added
the
Backport to WP Beta/RC
|
@c4rl0sbr4v0 @ockham a corresponding PR against wordpress-develop will be needed to backport this into WordPress 6.0. Would you please create one? Edit: or will it? If no unit tests break, we may be good here. |
adamziel
pushed a commit
that referenced
this pull request
Apr 29, 2022
We have both singular and plural editing on the comment title. Also, we have an option for showing comments count or not. In singular, this last option was not taken into account, showing always the same placeholder. 'One response' Also, to keep consistency, we change uppercase or lowercase on R letter of Response depending on we are enabling or disabling the comments count.
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP Beta/RC
|
@adamziel I don't think these can go in to 6.0 because of the string freeze last week. The exception to that would be to use the existing strings in WP comments. The logic seems to be a little off too. My understanding is that some languages may replace the function with something that considers different forms for more than two strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #40541
Also, to keep consistency, we change uppercase or lowercase on R letter of Response depending on we are enabling or disabling the comments count.
Why?
We have both singular and plural editing on the comment title. Also, we have an option for showing comments count or not.
In singular, this last option was not taken into account, showing always the same placeholder. 'One response'
How?
Adding new strings placeholders.
Testing Instructions
1.) Go to site editor -> single template. Add Comments Query Loop.
2.) Click on Comments Title block. Play with the different options.
3.) Check that placeholders are being updated depending on Comments Count and Singular/Plural.
4.) Save and check that the frontend is applying those placeholders.
Screenshots or screencast
https://www.loom.com/share/43d3e66bde534d7dac86b2040e2a03fe