Fix alignment issue with comment author name #40610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Bug
cbravobernal
force-pushed
the
update/comment-author-name-classes
branch
from
7e8b7e3
to
3e952a7
Compare
|
LGTM! |
cbravobernal
approved these changes
Apr 26, 2022
adamziel
added
the
Backport to WP Beta/RC
adamziel
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Remove duplicate font size class * Update unit tests Co-authored-by: Carlos Bravo <carlos.bravo@automattic.com>
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is the equivalent of #40582 but for the comment author name.
Closes #40251
Assures that the comment author name text alignment setting works and that the block displays correctly on the front.
Also removes duplicate escaping.
Why?
The block had duplicate font-size classes on the front. This caused the alignment class and the font size class to be output as one word without spacing in between them, and the CSS was not applied. Because of this, the alignment option did not work.
How?
By removing the extra output of the font size class, the class name for the text alignment is correct and the CSS applied.
Testing Instructions
Screenshots or screencast
Editor, with right alignment selected:
Front, with link color, to show that both color options work:
With text color instead of link color:
