-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env: Do not support newer PHPunit versions #29325
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Package] Env
/packages/env
[Type] Build Tooling
Issues or PRs related to build tooling
labels
Feb 25, 2021
Related: #29323 |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
noahtallen
force-pushed
the
try/fix-phpunit-version-issue
branch
from
April 9, 2021 00:43
18b7c2b
to
92c9f7c
Compare
I came across this PR while checking out old PRs. It appears that the changes being made by this PR no longer exist in trunk. Is this PR still valid? |
Probably not! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WP test library does not support newer PHPunit versions. This means that one cannot simultaneously set a "php version" and also use the recommended WP test library.
My proposal is to just support up to the "latest" tagged image, which is currently 7. However, this would obviously break things if you're trying to work with PHP 8.... Then again, you wouldn't be able to use the WP tests lib with that anyways. 🤔 Not sure what the best path forward is in that scenario.
What do folks think?
How has this been tested?
Also, GH actions phpunit step should pass.
Types of changes
bug fix
Checklist: