Block Editor: Add hook: useNoRecursiveRenders #28428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally introduced in #28405 to prevent Reusable Blocks from infinitely and fatally recurring, React hook `useNoRecursiveRenders` has a place in the block-editor package so that other block types susceptible to recursion can be fixed too.
mcsf
added
[Type] Code Quality
6 tasks
|
Size Change: +42 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 22, 2021
| return result; | ||
| } | ||
|
|
||
| export default function useNoRecursiveRenders( uniqueId ) { |
There was a problem hiding this comment.
JSDoc comment with an example should help create README.md once it gets promoted stable. In addition, it will make it easier to type the package with TS in the future.
There was a problem hiding this comment.
How's this? 1c3b036
I'm not familiar with our latest typing practice. Do you have a specific React type you recommend for the returned provider? For now I just used Function.
There was a problem hiding this comment.
Yes, this is exactly what I meant 👍🏻
If you think it deserves an example, you can use the following syntax:
gutenberg/packages/plugins/src/components/plugin-area/index.js
Lines 38 to 50 in 1608a02
aristath
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up on #28405.
Originally introduced in #28405 to prevent Reusable Blocks from infinitely and fatally recurring, React hook
useNoRecursiveRendershas a place in theblock-editorpackage so that other block types susceptible to recursion can be fixed too.This hook is marked as experimental, available under the name
__experimentalUseNoRecursiveRenders.Along with the move, the hook was refactored to:
ref(an allusion to therefattribute of Reusable Blocks) becomesuniqueId.Setinstead ofArrayto keep track of previously rendered blocks.How has this been tested?
This change should have no observable effects.
Types of changes
Refactor; new API
Checklist: