FormTokenField: handle disabled in Token; add storybook stories #23713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `disabled` prop was not passed to the `Button`, which made it clickable (the click would not be handled, but the DOM element was focusable).
adekbadek
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
6 tasks
|
I checked the latest trunk and it appears that Storybook has already been added in #25439. However, the problem of the focus outline appearing on the button still seems to exist. 1a3bc61bf05b10a49ee91c5d57348a1d.mp4 |
|
@adekbadek Are you still available to resolve the conflict and remove the Storybook bit? If not, let us know and we'll find someone to take over 🙂 |
|
Hi @mirka – I don't have bandwidth to do that currently, if it's possible please take over. |
|
I've just taken a look and with the existing Storybook setup, it does look like all we need is to pass that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
FormTokenFieldcomponent, thedisabledprop was not passed to theButton, which made the delete button clickable. The click would not be handled, but the DOM element was focusable. This PR fixes that by passing thedisabledprop to theButton.How has this been tested?
Locally. Storybook stories were added for the
FormTokenFieldcomponent for ease of testing.Screenshots
Focusing on the token when the component is disabled:
Types of changes
Checklist: