Directory

NavigatorButton has double border on focus state · Issue #61621 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigatorButton has double border on focus state #61621

Open
madhusudhand opened this issue May 13, 2024 · 1 comment
Open

NavigatorButton has double border on focus state #61621

madhusudhand opened this issue May 13, 2024 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended

Comments

@madhusudhand
Copy link
Contributor

Description

When NavigatorButton is added inside ItemGroup, the last item gives double order on focus.

image

Step-by-step reproduction instructions

  • Navigate to typography section in global styles menu
  • In Elements item group, change the focus state of last item.
  • Observe that there is double border.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@madhusudhand madhusudhand added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels May 13, 2024
@madhusudhand madhusudhand mentioned this issue May 13, 2024
Merged
8 tasks
@mirka
Copy link
Member

mirka commented May 20, 2024

Reproduced in Storybook. Last item is <Item as={ NavigatorButton } path="/foo" />. Not sure if we should call it a double border, but we can see the button styles (border radius) taking precedence.

CleanShot.2024-05-21.at.07.02.27.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirka @madhusudhand