Directory

typo - build/editor/index.js · Issue #61053 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo - build/editor/index.js #61053

Closed
timse201 opened this issue Apr 24, 2024 · 1 comment · Fixed by #61087
Closed

typo - build/editor/index.js #61053

timse201 opened this issue Apr 24, 2024 · 1 comment · Fixed by #61087
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@timse201
Copy link

timse201 commented Apr 24, 2024 •
edited

Description

a unnecessary point at the end of the sentence.

You’ve tried to select a block that is part of a template, which may be used on other posts and pages. Would you like to edit the template?->.<-

Step-by-step reproduction instructions

build/editor/index.js:18925
build/editor/index.min.js:21083

https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/de/default/?filters%5Boriginal_id%5D=17610391

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@timse201 timse201 added the [Type] Bug An existing feature does not function as intended label Apr 24, 2024
@t-hamano
Copy link
Contributor

Thanks for the report. We need to fix this line:

gutenberg/packages/editor/src/components/editor-canvas/edit-template-blocks-notification.js

Line 85 in 6d444aa

'You’ve tried to select a block that is part of a template, which may be used on other posts and pages. Would you like to edit the template?.'

@t-hamano t-hamano added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor labels Apr 25, 2024
@itzmekhokan itzmekhokan mentioned this issue Apr 25, 2024
Merged
@talldan talldan linked a pull request Apr 26, 2024 that will close this issue
Remove unnecessary period in template block selection notice #61087
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary period in template block selection notice itzmekhokan/gutenberg
2 participants
@timse201 @t-hamano