Directory

[Flaky Test] the event listener is removed when the element is removed · Issue #57983 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] the event listener is removed when the element is removed #57983

Closed
github-actions bot opened this issue Jan 18, 2024 · 0 comments · Fixed by #58008, #58134 or #58181
Closed

[Flaky Test] the event listener is removed when the element is removed #57983

github-actions bot opened this issue Jan 18, 2024 · 0 comments · Fixed by #58008, #58134 or #58181
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Jan 18, 2024

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

the event listener is removed when the element is removed

Test path

/test/e2e/specs/interactivity/directive-on-window.spec.ts

Errors

[2024-01-18T19:21:52.904Z] Test passed after 1 failed attempt on trunk.
[2024-01-18T20:37:42.564Z] Test passed after 1 failed attempt on add/legacy-adapter-customselectcontrol.
[2024-01-18T20:56:31.815Z] Test passed after 1 failed attempt on add/legacy-adapter-customselectcontrol.
[2024-01-18T21:16:17.065Z] Test passed after 1 failed attempt on try/avoid-fetching-themes.
[2024-01-18T22:30:52.651Z] Test passed after 1 failed attempt on try/query-avoid-requests.
[2024-01-18T22:58:10.736Z] Test passed after 1 failed attempt on try/query-avoid-requests.
[2024-01-18T23:23:58.782Z] Test passed after 1 failed attempt on add/editable-block-outlines.
[2024-01-18T23:46:40.221Z] Test passed after 1 failed attempt on fix/preferences-interface-backward-compatibility-edit-post-to-core.
[2024-01-18T23:54:44.243Z] Test passed after 1 failed attempt on add/editable-block-outlines.
[2024-01-19T04:38:00.150Z] Test passed after 1 failed attempt on try/reduce-global-styles-specificity.
[2024-01-19T04:47:41.288Z] Test passed after 1 failed attempt on update/modal-aria-inert.
[2024-01-19T04:57:56.285Z] Test passed after 1 failed attempt on try/dimensions-aspect-ratio-block-support.
[2024-01-19T05:00:33.769Z] Test passed after 1 failed attempt on rnmobile/prevent-image-flicker-when-uploading.
[2024-01-19T05:18:20.884Z] Test passed after 1 failed attempt on try/editor-canvas-template-selection.
[2024-01-19T05:20:57.394Z] Test passed after 2 failed attempts on try/reduce-global-styles-specificity.
[2024-01-19T06:38:05.508Z] Test passed after 1 failed attempt on fix/undefined-overrides-patch.
[2024-01-19T08:38:13.836Z] Test passed after 1 failed attempt on update/post-navigation-link-filters.
[2024-01-19T08:44:34.634Z] Test passed after 1 failed attempt on try/query-avoid-requests.
[2024-01-19T09:20:07.871Z] Test passed after 1 failed attempt on i-api-docs.
[2024-01-19T10:16:32.498Z] Test passed after 1 failed attempt on add-effects-block-inspector-panel.
[2024-01-19T10:17:59.920Z] Test passed after 1 failed attempt on trunk.
[2024-01-19T10:33:12.303Z] Test passed after 1 failed attempt on try/query-avoid-requests.
[2024-01-19T10:41:19.668Z] Test passed after 1 failed attempt on i-api-docs.
[2024-01-19T10:59:23.962Z] Test passed after 1 failed attempt on trunk.
[2024-01-19T11:03:51.704Z] Test passed after 1 failed attempt on trunk.
[2024-01-19T12:51:56.306Z] Test passed after 1 failed attempt on docs/version-wordpress-minor.
[2024-01-19T13:57:49.265Z] Test passed after 1 failed attempt on embed/fix-trailing-slash-retry.
[2024-01-19T14:10:21.844Z] Test passed after 1 failed attempt on try/registry-selectors-switching-registries.
[2024-01-19T14:19:52.699Z] Test passed after 1 failed attempt on fix/ios-highlight-text-functionality.
[2024-01-19T14:23:08.931Z] Test passed after 1 failed attempt on add/interactivity-api-wp-each.
[2024-01-19T15:14:37.825Z] Test passed after 1 failed attempt on update/refactor-site-editor-router.
[2024-01-19T16:14:24.664Z] Test passed after 1 failed attempt on try/new-rich-text-link-invoking-ux.
[2024-01-19T16:28:37.428Z] Test passed after 1 failed attempt on refactor/search-control-consumers.
[2024-01-19T16:42:47.348Z] Test passed after 1 failed attempt on update/shim-deprecated-preferences.
[2024-01-19T17:03:01.614Z] Test passed after 1 failed attempt on add/auto-wrapping.
[2024-01-19T18:13:02.740Z] Test passed after 1 failed attempt on add/auto-wrapping.
[2024-01-19T19:24:13.664Z] Test passed after 1 failed attempt on docs/remove-emoji-from-beh.
[2024-01-19T19:38:11.895Z] Test passed after 1 failed attempt on remove/version-from-font-collection-schema.
[2024-01-19T19:55:04.324Z] Test passed after 1 failed attempt on trunk.
[2024-01-19T20:00:06.578Z] Test passed after 1 failed attempt on revert/bump-to-v17.5.1.
[2024-01-19T20:14:03.500Z] Test passed after 1 failed attempt on try/font-library-refactor.
[2024-01-19T20:30:38.312Z] Test passed after 1 failed attempt on try/inert-block-editor-provider.
[2024-01-19T21:03:34.073Z] Test passed after 1 failed attempt on trunk.
[2024-01-19T22:30:46.592Z] Test passed after 1 failed attempt on try/avoid-patterns-fetching-on-load-3.
[2024-01-20T05:29:12.196Z] Test passed after 1 failed attempt on fixed-header-custom-scroll.
[2024-01-20T23:39:10.259Z] Test passed after 1 failed attempt on add/lightbox-toolbar-ui.
[2024-01-22T05:49:33.901Z] Test passed after 1 failed attempt on fix/block-style-variation-selectors.
[2024-01-22T05:51:21.996Z] Test passed after 1 failed attempt on update/block-bindings-to-use-wp-kses-for-content.
[2024-01-22T07:03:07.845Z] Test passed after 1 failed attempt on update-global-style-name.
[2024-01-22T07:53:25.637Z] Test passed after 1 failed attempt on try/navigation-relation-meta.
[2024-01-22T08:34:43.176Z] Test passed after 1 failed attempt on update/refactor-block-bindings-editor-code.
[2024-01-22T09:51:53.121Z] Test passed after 1 failed attempt on experiment/flexi-grid-component.
[2024-01-22T10:18:27.820Z] Test passed after 1 failed attempt on trunk.
[2024-01-22T10:58:12.808Z] Test passed after 1 failed attempt on try/document-files-needing-back-merging.
[2024-01-22T11:17:37.150Z] Test passed after 1 failed attempt on fix/url-decode-error-navigation-link.
[2024-01-22T11:19:26.743Z] Test passed after 1 failed attempt on trunk.
[2024-01-22T11:22:25.384Z] Test passed after 1 failed attempt on try/fix-nav-link-block-php-errors.
[2024-01-22T11:43:08.805Z] Test passed after 1 failed attempt on interactivity-api-server-directive-processing-refactoring.
[2024-01-22T12:07:40.598Z] Test passed after 1 failed attempt on skip/nav-link-variation-tests.
[2024-01-22T12:39:31.900Z] Test passed after 1 failed attempt on add-effects-block-inspector-panel.
[2024-01-22T14:40:08.031Z] Test passed after 1 failed attempt on add/element-pure-component.
[2024-01-22T14:42:07.500Z] Test passed after 1 failed attempt on trunk.
[2024-01-22T14:46:14.189Z] Test passed after 1 failed attempt on add/link-to-dataviews-preview.
[2024-01-22T14:52:26.867Z] Test passed after 1 failed attempt on fix/site-editor-layout.
[2024-01-22T14:59:29.137Z] Test passed after 1 failed attempt on add/interactivity-api-wp-each.
[2024-01-22T15:20:04.310Z] Test passed after 1 failed attempt on add/interactivity-api-wp-each.
[2024-01-22T16:36:48.662Z] Test passed after 1 failed attempt on add/block-bindings-support-in-the-editor.
[2024-01-22T16:44:05.096Z] Test passed after 1 failed attempt on fix/site-editor-layout.
[2024-01-22T17:08:23.222Z] Test passed after 1 failed attempt on update-caniuse.
[2024-01-22T18:20:50.319Z] Test passed after 1 failed attempt on rnmobile/check-existence-of-richtext-value.
[2024-01-22T18:23:25.300Z] Test passed after 1 failed attempt on update/block-bindings-remove-experimental-flag.
[2024-01-22T18:29:16.613Z] Test passed after 1 failed attempt on trunk.
[2024-01-22T18:46:28.536Z] Test passed after 1 failed attempt on update/block-bindings-remove-experimental-flag.
[2024-01-22T18:53:56.332Z] Test passed after 1 failed attempt on tabs-editor-settings-manual-activation.
[2024-01-22T19:10:59.884Z] Test passed after 1 failed attempt on fix/ios-highlight-text-functionality.
[2024-01-22T19:11:26.508Z] Test passed after 1 failed attempt on try/fixing-php-unit-variations.
[2024-01-22T19:31:57.591Z] Test passed after 1 failed attempt on fix/font-collection-filters.
[2024-01-22T19:33:07.097Z] Test passed after 1 failed attempt on try/fixing-php-unit-variations.
[2024-01-22T21:19:14.342Z] Test passed after 1 failed attempt on fix/sytem-fonts-ui.
[2024-01-22T22:07:34.887Z] Test passed after 1 failed attempt on fix/ios-highlight-text-functionality.
[2024-01-22T23:21:31.705Z] Test passed after 1 failed attempt on trunk.
[2024-01-23T00:10:37.565Z] Test passed after 1 failed attempt on refactor/template-only-mode-in-post-editor.
[2024-01-23T00:59:54.934Z] Test passed after 2 failed attempts on add/legacy-adapter-customselectcontrol.
[2024-01-23T01:18:56.216Z] Test passed after 1 failed attempt on trunk.
[2024-01-23T01:21:17.462Z] Test passed after 1 failed attempt on refactor/template-only-mode-in-post-editor.
[2024-01-23T01:24:04.648Z] Test passed after 1 failed attempt on try/add-clipboard-events-to-the-list-view.
[2024-01-23T02:24:35.309Z] Test passed after 1 failed attempt on fix/theme-json-styles-scope-root-selector.
[2024-01-23T03:33:56.775Z] Test passed after 1 failed attempt on refactor/template-only-mode-in-post-editor.
[2024-01-23T04:25:12.308Z] Test passed after 2 failed attempts on update/individual-blocks-to-use-pattern-context.
[2024-01-23T05:08:14.922Z] Test passed after 1 failed attempt on trunk.
[2024-01-23T05:37:30.694Z] Test passed after 1 failed attempt on rnmobile/release_1.110.1.
[2024-01-23T06:06:07.457Z] Test passed after 1 failed attempt on rnmobile/release_1.110.1.
[2024-01-23T07:04:55.120Z] Test passed after 1 failed attempt on try/drag-into-row.
[2024-01-23T07:12:27.372Z] Test passed after 1 failed attempt on docs/fix-typo-block-wrapper.
[2024-01-23T07:12:54.944Z] Test passed after 1 failed attempt on update/revert-list-view-as-default-for-templates.
[2024-01-23T07:20:32.096Z] Test passed after 1 failed attempt on html-api/backport-scan-all-tokens.
[2024-01-23T07:23:54.600Z] Test passed after 1 failed attempt on try/drag-into-row.
[2024-01-23T07:26:41.931Z] Test passed after 1 failed attempt on remove/pattern-override-experiment-completely.
[2024-01-23T07:43:58.538Z] Test passed after 1 failed attempt on update/revert-list-view-as-default-for-templates.
[2024-01-23T08:39:09.382Z] Test passed after 1 failed attempt on fix/view-table-wrapper-html-block-previews.
[2024-01-23T08:48:59.358Z] Test passed after 1 failed attempt on update/individual-blocks-to-use-pattern-context.
[2024-01-23T08:50:59.092Z] Test passed after 1 failed attempt on docs/fix-typo-block-wrapper.
[2024-01-23T09:07:40.641Z] Test passed after 1 failed attempt on trunk.
[2024-01-23T09:21:33.816Z] Test passed after 1 failed attempt on refactor/block-setting-dropdown-to-v2.
[2024-01-23T09:38:09.063Z] Test passed after 1 failed attempt on migrate/inserting-blocks-e2e-tests.
[2024-01-23T09:51:02.064Z] Test passed after 1 failed attempt on update/revert-list-view-as-default-for-pages.
[2024-01-23T09:56:37.884Z] Test passed after 1 failed attempt on migrate/inserting-blocks-e2e-tests.
[2024-01-23T11:16:48.243Z] Test passed after 1 failed attempt on fix-avatar-alignments.
[2024-01-23T15:37:54.027Z] Test passed after 1 failed attempt on tabs-editor-settings-manual-activation.
[2024-01-23T15:45:48.715Z] Test passed after 1 failed attempt on trunk.
[2024-01-23T15:50:24.041Z] Test passed after 1 failed attempt on try/keep-link-ui-open-on-initial-link-creation.
[2024-01-23T18:04:19.870Z] Test passed after 1 failed attempt on update/grid-for-patterns-stable.
[2024-01-23T22:23:02.112Z] Test passed after 1 failed attempt on try/new-rich-text-link-invoking-ux.
[2024-01-24T02:24:07.359Z] Test passed after 1 failed attempt on tabs-editor-settings-manual-activation.
[2024-01-24T05:47:45.197Z] Test passed after 1 failed attempt on try/rememo-map-tree.
[2024-01-24T12:12:36.795Z] Test passed after 1 failed attempt on interactivity-api-server-directive-processing-refactoring.
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

Locator: getByTestId('counter')
Expected string: "2"
Received string: "1"
Call log:
  - expect.toHaveText with timeout 5000ms
  - waiting for getByTestId('counter')
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>1</p>
  -   unexpected value "1"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/directive-on-window.spec.ts:43:27
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jan 18, 2024
github-actions bot referenced this issue Jan 18, 2024
…directives (#57931)

* Add wp-data-on-window and wp-data-on-document directives

* Update changelog

* Rename directives tests files to unify them

* Use callbacks instead of actions, remove not needed counter

* Add event listener removal tests

* Add documentation

* Test that events are reattached

* Fix docs typos

* Fix docs typos

* Fix indentation in docs

* Fix e2e test
github-actions bot referenced this issue Jan 19, 2024
)

* Initial script

* Linting fun

* Add primitve docs to args

* Ensure since arg cannot be far into the past

* Refactor to avoid passing around octokit vars

* Handle network errors

* Refactor method names to use “fetch” terminology

* Ignore block-library as these changes are handled automatically

* Allow sections with a single PR to remain

* Allow any commit that modifies tests to be also under another section

* Remove block-library specific handling

* Use const to define max nesting level

* Automate ignore of previous release compat dir

* Exclude load.php as it is Plugin specific

* Remove ping debugging

* Prepare for requiring full PR label data

* Flag PRs that may have already been backported

* Fix output of `undefined`

* Tweak warning

* Ignore PRs with given labels

* Update instructions for new label

* Update since arg description
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 19, 2024
github-actions bot referenced this issue Jan 22, 2024
#56625)

* Include earlier experiment to make drag chip resemble the list view item

* Try displacing list view items via transform: translateY while dragging

* Try adding a bit of styling when nesting

* Try to fix tests

* Offset the top of the table to match the displacement

* Improve the experience when beginning to drag a block

* Smoothly hide gap when dragging outside of the list view area

* Merge in changes from drag to collapsed block to expand PR

* Try collapsing selected blocks down to a single row space while dragging

* Fix jumpiness in Safari

* Try making styling match the selected state

* Try smoothly dropping to the final position

* Fix transitions above dragged items

* Fix flickering issue in Safari

* Try a transparent background color

* Fix drag behaviour in navigation block

* Add vertical drop indicator

* Try using existing drop indicator line

* Add reduced motion, fix e2e test

* Tidy up classname for drag chip in prep for subsequent changes

* Remove indent from drop chip, ensure indent is applied to the position

* Try updating the drag chip to use a border

* Try drop indicator line as preview of final list item

* Try offsets for nesting level of drop indicator, and use darker color if adjacent block has selected branch

* Use drag chip as on trunk, but with opacity of 0.8

* Consolidate drop indicator logic

* Fix drop indicator when dragging files

* Don't add nesting classname when dragging files as the editor thinks we can nest for any block

* Move displacement logic to a helper function, add tests

* Remove unneeded changes from useMovingAnimation

* Add explanatory comments

* Try a timeout for the list view drop zone updates of 50ms instead of 200ms
github-actions bot referenced this issue Jan 23, 2024
* removing files and files loading no longer needed

* redeclaration guard in load.php

* format php

* Removes all tests

* Comment adjustments to load.php

---------

Co-authored-by: hellofromtonya <tonya.mork@automattic.com>
github-actions bot referenced this issue Jan 23, 2024
* Add pattern/overrides context to individual block.json files

* Remove addition of block context usage via blocks supports

* Add overrides attribute to pattern block and share it via providesContext

* Revert "Add overrides attribute to pattern block and share it via providesContext"

This reverts commit aca9b906e676a16bfa117ebfaa406e9141b72817.

* Remove the experiment flag after reverting pattern block index.php changes

* Register overrides attribute in block.json
@github-actions github-actions bot reopened this Jan 23, 2024
github-actions bot referenced this issue Jan 23, 2024
…#58071)

* DataViews: Make patterns and templates preview a button

* add button to pages preview

* focus styles

* Use focus-visible

* use buttons even if a media/preview is missing

* Page / Template preview should always link to editor

* render button only for editable patterns

* Templates: Add "Empty template" text

* Patterns: Apply border-radius to locked patterns

* fixes from rebase

---------

Co-authored-by: James Koster <james@jameskoster.co.uk>
Co-authored-by: Tetsuaki Hamano <tetsuaki.hamano@gmail.com>
@github-actions github-actions bot reopened this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
1 participant