Directory

Mentions Autocomplete is re-rendeing on each keypress · Issue #55299 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions Autocomplete is re-rendeing on each keypress #55299

Closed
WunderBart opened this issue Oct 12, 2023 · 2 comments
Closed

Mentions Autocomplete is re-rendeing on each keypress #55299

WunderBart opened this issue Oct 12, 2023 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@WunderBart
Copy link
Member

WunderBart commented Oct 12, 2023 •
edited

Description

Originally mentioned in #55118 (comment)

The constant rerendering of the results popup is causing issues for accessibility.

The responsible part seems to be the popup cloning via createPortal as it does not rerender when that part is removed. Kudos to @chad1008 for pinning it down.

cc: @ellatrix, since you worked on this part recently.

Step-by-step reproduction instructions

  1. create a new post
  2. type "@" to trigger the mentions autocomplete popup
  3. navigate the results with arrow down/up and notice the rendering

Screenshots, screen recording, code snippet

Screen.Recording.2023-10-06.at.11.40.02.copy.mov

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No
@WunderBart WunderBart mentioned this issue Oct 12, 2023
Closed
@WunderBart WunderBart added the [Type] Bug An existing feature does not function as intended label Oct 12, 2023
@jordesign jordesign added the [Package] Editor /packages/editor label Oct 12, 2023
@alexstine alexstine added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Oct 12, 2023
@alexstine
Copy link
Contributor

Labeling this as low priority. Not urgent that this gets fixed, just something to improve on later.

@alexstine alexstine mentioned this issue May 23, 2024
Merged
@jsnajdr
Copy link
Member

jsnajdr commented May 23, 2024

Fixed by #61877.

@jsnajdr jsnajdr closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsnajdr @WunderBart @jordesign @alexstine