Directory

'Header' used in i18n functions without gettext context · Issue #51063 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Header' used in i18n functions without gettext context #51063

Closed
gonzomir opened this issue May 29, 2023 · 0 comments · Fixed by #51066
Closed

'Header' used in i18n functions without gettext context #51063

gonzomir opened this issue May 29, 2023 · 0 comments · Fixed by #51066
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Interface /packages/interface [Type] Enhancement A suggestion for improvement.

Comments

@gonzomir
Copy link
Contributor

gonzomir commented May 29, 2023 •
edited

What problem does this address?

It is currently difficult to translate the word 'Header' because it appears also in Core in the context of header image and is already translated in this context. Now the word appears in the block and site editors in the context of header landmark region, and when it's merged into core it 'inherits' the translations made in the context of header image.

What is your proposed solution?

My proposal is to always use gettext context when 'Header' appears as translatable string.
@gonzomir gonzomir mentioned this issue May 29, 2023
Merged
@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. Internationalization (i18n) Issues or PRs related to internationalization efforts [Block] Template Part Affects the Template Parts Block labels May 29, 2023
@Mamaduka Mamaduka added [Package] Interface /packages/interface and removed [Block] Template Part Affects the Template Parts Block labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Interface /packages/interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add gettext content when translating 'Header'. gonzomir/gutenberg
3 participants
@Mamaduka @gonzomir @kathrynwp