Directory

Global Styles: Border setting for Table block doesn't work as you expect · Issue #50850 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Border setting for Table block doesn't work as you expect #50850

Open
Tracked by #32400
iamtakashi opened this issue May 22, 2023 · 2 comments · May be fixed by #55047
Open
Tracked by #32400

Global Styles: Border setting for Table block doesn't work as you expect #50850

iamtakashi opened this issue May 22, 2023 · 2 comments · May be fixed by #55047
Labels
[Block] Table Affects the Table Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

The border setting for the table block in Global Styles doesn't seem to be working correctly.

Let's say I wanted like to change the 1px border colour for all the table block to orange... but nothing changed.

Screenshot 2023-05-22 at 17 59 42

If I increased the width of the border to more than 1px... The outer border started to appear, but the ones inside the table stayed 1px and the default colour.
Screenshot 2023-05-22 at 18 01 29

If I tried to change the border of the table locally, the setting seemed work as expectedly.

Screenshot 2023-05-22 at 18 06 31

Step-by-step reproduction instructions

  1. Go to the site editor.
  2. Add a table block with some contents
  3. Go to Global Styles and change the table block border globally (colour and width.)

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 6.2.2
  • Gutenberg trunk
  • Chrome Mac

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added Needs Testing Needs further testing to be confirmed. [Block] Table Affects the Table Block labels May 23, 2023
@t-hamano
Copy link
Contributor

Thanks for the report. I was also able to reproduce this problem.

When I changed the border settings from the block sidebar they applied correctly, but when I change the settings from the global style, the inner border color does not change.

@t-hamano t-hamano added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json and removed Needs Testing Needs further testing to be confirmed. labels Jun 17, 2023
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Jul 20, 2023
@faisal-alvi faisal-alvi linked a pull request Oct 4, 2023 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 4, 2023
@faisal-alvi
Copy link
Contributor

Raised a PR #55047

@jeffpaul jeffpaul mentioned this issue Oct 4, 2023
Open
33 tasks
@faisal-alvi faisal-alvi mentioned this issue Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Table Affects the Table Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/50850 Global Style applied correctly to the table block faisal-alvi/gutenberg
4 participants
@iamtakashi @jordesign @faisal-alvi @t-hamano