Directory

Make the Grouping and Ungrouping interaction labels customizable. · Issue #49675 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Grouping and Ungrouping interaction labels customizable. #49675

Open
aurooba opened this issue Apr 9, 2023 · 1 comment · May be fixed by #49674
Open

Make the Grouping and Ungrouping interaction labels customizable. #49675

aurooba opened this issue Apr 9, 2023 · 1 comment · May be fixed by #49674
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@aurooba
Copy link
Member

aurooba commented Apr 9, 2023

What problem does this address?

I am using the setGroupingBlockName function found in @wordpress/blocks very effectively for a few use cases. The problem is that the labels Group and Ungroup are hard coded into the UI and unchangeable. It doesn't always make sense to have those labels stay the same. For example, if the groupingBlock is core/quote, I'd prefer the label for the grouping interaction to say Add to Quote and the label for the ungrouping interaction Unquote.

What is your proposed solution?

Adding two publicly available functions that set the labels. I started a draft PR #49674 here, which I can finalize/update if this seems like addition the team wants to go through with.
@aurooba aurooba linked a pull request Apr 9, 2023 that will close this issue
Draft
@annezazu annezazu added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Extensibility The ability to extend blocks or the editing experience labels Apr 10, 2023
@aurooba
Copy link
Member Author

aurooba commented Apr 10, 2023

There is also maybe the possibility of combining the labels for Group and Ungroup into one function, since they are so closely tied together.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
3 participants
@jordesign @aurooba @annezazu