Directory

[RNMobile] Numbered list crashes with very large · Issue #39727 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Numbered list crashes with very large #39727

Closed
jhnstn opened this issue Mar 24, 2022 · 8 comments
Closed

[RNMobile] Numbered list crashes with very large #39727

jhnstn opened this issue Mar 24, 2022 · 8 comments
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects

Comments

@jhnstn
Copy link
Contributor

jhnstn commented Mar 24, 2022

Description

Adding a very large starting number to an numbered list crashes the editor. (cc @twstokes )

Step-by-step reproduction instructions

  1. Add a numbered list to a post
  2. Open the block settings
  3. Enter a very large number as the start value e.g. 10000000000

Expected behaviour

The editor should not crash.

Actual behaviour

The editor crashes

Screenshots or screen recording (optional)

screen-20220324-122224.mp4

WordPress information

  • Gutenberg version: 1.72.0

Device information

  • Device: Pixel 6
  • Operating system: Android 12
  • WordPress app version: WPAndroid 19.5-rc-1
@jhnstn jhnstn added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 24, 2022
@jhnstn
Copy link
Contributor Author

jhnstn commented Mar 24, 2022

@hypest Looks like this is an integer overflow issue. Give 2147483647((2^31)-1) a try and it works, add 1 to get 2147483648 and 💥
The error is from this toInt() call in Aztec.

2^31 works fine on an iPhone, guessing since they are 64bit. The UI does get a little weird at 1e+20 but the editor doesn't crash. It just resets back to 1.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2022
@hypest hypest added Mobile App - Automation Label used to initiate Mobile App PR Automation and removed Mobile App - Automation Label used to initiate Mobile App PR Automation labels Mar 28, 2022
@hypest hypest added this to Triage in Mobile Apps via automation Mar 28, 2022
@hypest hypest moved this from Triage to In progress in Mobile Apps Mar 28, 2022
@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
@Thelmachido
Copy link

Hi @jhnstn there hasn't been much activity lately on this issue or the PR, just popping in to check if there’s still a plan to move this forward.

@ndiego
Copy link
Member

ndiego commented Oct 25, 2022

This issue was reviewed in today's Editor Bug Scrub and just wanted to follow up on @Thelmachido's last comment. Any updates on the progress of the linked PR?

@jhnstn
Copy link
Contributor Author

jhnstn commented Oct 25, 2022

The linked PR was put on hold for higher priority work. I plan on picking it back up this week to clear this issue.

@Thelmachido
Copy link

Hi @jhnstn any plans for moving this forward?

@jhnstn
Copy link
Contributor Author

jhnstn commented Nov 9, 2022

Hi @Thelmachido yes, I was able to review the work done so far but haven't been able to make some requested updates. I should have time next week to look into it.

@bph bph removed the Needs Testing Needs further testing to be confirmed. label Nov 9, 2022
@jhnstn
Copy link
Contributor Author

jhnstn commented Mar 13, 2023

This issue is no longer reproducible. I suspect the move to Android 12 had something to do with the fix.

@jhnstn jhnstn closed this as completed Mar 13, 2023
Mobile Apps automation moved this from In progress to Done Mar 13, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
Mobile Apps
  
Done
6 participants