-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Numbered list crashes with very large #39727
Comments
@hypest Looks like this is an integer overflow issue. Give 2^31 works fine on an iPhone, guessing since they are 64bit. The UI does get a little weird at 1e+20 but the editor doesn't crash. It just resets back to 1. |
Hi, |
Hi @jhnstn there hasn't been much activity lately on this issue or the PR, just popping in to check if there’s still a plan to move this forward. |
This issue was reviewed in today's Editor Bug Scrub and just wanted to follow up on @Thelmachido's last comment. Any updates on the progress of the linked PR? |
The linked PR was put on hold for higher priority work. I plan on picking it back up this week to clear this issue. |
Hi @jhnstn any plans for moving this forward? |
Hi @Thelmachido yes, I was able to review the work done so far but haven't been able to make some requested updates. I should have time next week to look into it. |
This issue is no longer reproducible. I suspect the move to Android 12 had something to do with the fix. |
Description
Adding a very large starting number to an numbered list crashes the editor. (cc @twstokes )
Step-by-step reproduction instructions
Expected behaviour
The editor should not crash.
Actual behaviour
The editor crashes
Screenshots or screen recording (optional)
screen-20220324-122224.mp4
WordPress information
Device information
The text was updated successfully, but these errors were encountered: