Tests: use tests-wordpress wp-env for phpunit #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running tests on the `cli` environment causes coflicts with the `dev` environment; the tests will log you out, modify the theme, etc. Running tests on `tests-wordpress` will allow you to run tests along with the `dev` environment without interference.
matiasbenedetto
approved these changes
May 6, 2024
There was a problem hiding this comment.
I could reproduce this on trunk:
running npm run test:php would log you out and activate an invalid theme on your dev environment.
This branch doesn't affect the main container but breaks WordPress in the tests container, as it used to in the main dev container. I think that's unexpected and probably caused by problematic test cases we should fix.
Still, this change mitigates the problem so, I'm approving the PR, but doesn't solve it.
I think the follow-up of this PR is fixing the tests that break the WordPress instance in the tests container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests on the
clienvironment causes conflicts with thedevenvironment; the tests will log you out, modify the theme, etc.Running tests on
tests-wordpresswill allow you to run tests along with thedevenvironment without interference.Testing:
npm run wp-env startto start a WordPress environment.npm run test:phpwill work as before, and will not mess with the dev environment.Before applying this branch, running
npm run test:phpwould log you out and activate an invalid theme on your dev environment.