Check ZipArchive class before zip export #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Apr 30, 2024
| @@ -462,6 +462,9 @@ function blockbase_save_theme() { | |||
| $this->create_blank_theme( $_POST['theme'], $_FILES['screenshot'] ); | |||
|
|
|||
| add_action( 'admin_notices', array( 'Form_Messages', 'admin_notice_blank_success' ) ); | |||
| } elseif ( ! class_exists( 'ZipArchive' ) ) { | |||
| // Avoid running if ZipArchive is not enabled. | |||
| add_action( 'admin_notices', array( 'Form_Messages', 'admin_notice_error_unsupported_zip_archive' ) ); | |||
There was a problem hiding this comment.
Everything after this should require the zipArchive class.
pbking
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
This PR displays an appropriate error message when a process that creates a zip file requires the ZipArchive class and the class does not exist.
Suggestions for displayed text are also welcome!
Testing Instructions
To test this PR, you need to disable the zip extension locally. For wp-env, please follow the steps below.
npm run wp-env startdocker psdocker exec -it {YOUR-CONTAINER-NAME}-wordpress-1 bashrm /usr/local/etc/php/conf.d/docker-php-ext-zip.ini/etc/init.d/apache2 reloadexitAfter that, confirm that an error message is displayed when you perform the following operations:
P.S. Restart wp-env and the zip extension will be automatically enabled again.
Supplement
In addition to the REST API endpoint that this PR changes, the ZipArchive class is also used in the callback functions of the following two endpoints. However, these two endpoints currently don't seem to be called from anywhere.