-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a theme.json editor #491
Comments
We don't recommend editing the theme's theme.json file though? I think this can easily create confusion as global style changes are saved for users during an update while a theme's theme.json file will be overwritten. |
I lean towards not trying to replicate a solid IDE; it's a lot of work and maintenance—for little benefit. |
Do we have a working list of these that we can help migrate to UI? Perhaps CBT can add the more nuanced theme.json controls that core may not add. CBT can add those that are more likely to be integrated as well, as initial explorations — much like how the font library progressed. This seems like a more rewarding effort. |
We do have them written down but they're not yet triaged. We're planning on publishing a roadmap for the plugin so I think that will help clear up the plans for what goes into CBT or Core.
I understand that it's not recommended, but from our recent discussions with theme builders, this is a sought-after feature. I think we could ship the simple version first and then see what the feedback is from there. |
Agreed - there are still SO many design possibilities in theme.json that you can't do in the site editor.
There are codemirror extensions (example) for showing JSON schema hints and linting which could be helpful for the initial version without too much overhead / debt. It would pull in basic info about theme.json and help you validate before saving. Just noting that it seems that the initial plan here (based on the PR) is to actually edit the current theme's |
I'm seeing that even theme builders who work mainly from the Global styles interface still need to directly edit theme.json files for some settings.
Adding a theme.json editor to Create Block Theme could have multiple benefits:
A super basic version of this would be enabling the existing theme file editor to access theme.json.
A more advanced version could use the schema of theme.json to show what options are available and valid for the area of the file you are working in, perhaps using autocomplete, or having a more structured interface, like checkboxes for booleans and drop-downs when there is a limited set of valid choices.
The text was updated successfully, but these errors were encountered: