Directory

Initial push of foundation for Tardis with no styling by karmatosed · Pull Request #165 · WordPress/community-themes · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial push of foundation for Tardis with no styling #165

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Initial push of foundation for Tardis with no styling #165

merged 1 commit into from
Apr 24, 2024

Conversation

karmatosed
Copy link
Member

This is an initial commit using Create Block theme as a foundation to start the collaboration for Tardis. What this has is:

  • Foundation theme.
  • Style folder

There will be issues created to work on specific aspects of this, it is just to start the development as per issue #164

@github-actions GitHub Actions
Copy link

Preview changes

I've detected changes to the following themes in this PR: Tardis.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

MaggieCabrera
MaggieCabrera reviewed Apr 19, 2024
View reviewed changes
tardis/styles/twentytwentyfour.json
{
"$schema": "https://schemas.wp.org/wp/6.5/theme.json",
"version": 2,
"title": "TwentyTwentyFour",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this but the title might look bad on the UI if we write them like this

MaggieCabrera
MaggieCabrera approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can get the ball rolling with this one

@carolinan
Copy link
Collaborator

My only concern is the trademark registered on the name TARDIS. Would it cover this?

@MaggieCabrera
Copy link
Collaborator

My only concern is the trademark registered on the name TARDIS. Would it cover this?

We should investigate that, but it's not a blocker, so I'm merging this. Let's revisit that when the theme is ready for publishing

@MaggieCabrera MaggieCabrera merged commit f0f6289 into trunk Apr 24, 2024
1 check passed
@vcanales vcanales deleted the TRY/tardis branch May 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieCabrera MaggieCabrera MaggieCabrera approved these changes

@carolinan carolinan Awaiting requested review from carolinan

Assignees
No one assigned
Labels
Theme: Archivist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karmatosed @carolinan @MaggieCabrera