Directory

Used get_template_directory_uri() instead of get_stylesheet_directory_uri() by shail-mehta · Pull Request #155 · WordPress/community-themes · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used get_template_directory_uri() instead of get_stylesheet_directory_uri() #155

Merged

Conversation

shail-mehta
Copy link
Contributor

@shail-mehta shail-mehta commented Mar 28, 2024

Poetry & Blue Note both are main theme

  • We need to add get_template_directory_uri() instead of get_stylesheet_directory_uri().
  • Also removed Image ids & classes in images

For Ex:

  • "id":15
  • class="wp-image-15"

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the changes to Poetry? They are already included in #152.

If you do that and then change the version number and update the changelog for Blue Note I'll upload the theme with the changes after the merge. Thank you for this!

blue-note/patterns/media-text.php Show resolved Hide resolved
blue-note/readme.txt Outdated Show resolved Hide resolved
@MaggieCabrera MaggieCabrera merged commit c345f66 into WordPress:trunk Apr 1, 2024
@shail-mehta shail-mehta deleted the update-template-uri-and-remove-id branch April 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants