GH Actions: minor tweaks #2424
Merged
GH Actions: minor tweaks #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `--checkstyle` for a lint job which doesn't display with `cs2pr`. * Remove a stray condition.
|
The test build failure is related to this issue: sebastianbergmann/php-code-coverage#1025.
Actually, let's just run that specific build against PHP 7.2. That should be fine. |
PHP 7.2 should be using PHPUnit 8, which doesn't use PHP Parser, so _fingers crossed_, this should solve the build failure.
GaryJones
approved these changes
Feb 16, 2024
dingo-d
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Actions: minor tweaks
--checkstylefor a lint job which doesn't display withcs2pr.GH Actions: move code coverage build without MbString to PHP 7.2
PHP 7.2 should be using PHPUnit 8, which doesn't use PHP Parser, so fingers crossed, this should solve the build failure.